Skip to content

Relax discovery logic #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 13, 2019
Merged

Relax discovery logic #454

merged 4 commits into from
May 13, 2019

Conversation

ali-ince
Copy link
Contributor

@ali-ince ali-ince commented May 9, 2019 •
edited
Loading

Currently, discovery process is very picky on what exceptions are treated as a try-next-router or abort-discovery. This PR relaxes the existing logic, and treats any exception as a try-next-router action and logs those exceptions at warning level.

@ali-ince ali-ince changed the title Add tests to verify connection error on commit behavior Relax discovery logic May 10, 2019
@ali-ince ali-ince requested a review from zhenlineo May 10, 2019 12:21
@zhenlineo zhenlineo merged commit e66c4e8 into neo4j:1.7 May 13, 2019
@ali-ince ali-ince deleted the 1.7-verify-error-on-commit branch July 3, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenlineo zhenlineo Awaiting requested review from zhenlineo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ali-ince @zhenlineo